Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix space-members access type to be set upon creation #7741

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix space-members access type to be set upon creation #7741

wants to merge 2 commits into from

Conversation

denasescu
Copy link

@denasescu denasescu commented Jan 22, 2024 •
edited
Loading

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@denasescu
Implements a factory method to return the MXSpaceCreationParameters…
61e875a 
… with .restricted join-rule together with default parameters. This object is then used as the parameter object for `createSpace` with parameter method.
@denasescu
Add changelog file
ba5a2d2 
Signed-off-by: Denisia Enasescu <[email protected]>
@denasescu
Copy link
Author

Steps to reproduce:

  • Open any space and choose Create a subspace.
  • Select Private, then enter any space name on the next screen.
  • When prompted for access, choose Me and teammates.
  • Select Next until subspace is created.
  • Go to Space Settings and inspect Access row. Notice that Private is set instead of Space members as it was set upon creation.

@denasescu denasescu changed the title Implements a factory method to return the MXSpaceCreationParameters… Fix space-members access type to be set upon creation Jan 22, 2024
@vpetrykov
Copy link

@SBiOSoftWhare / @ismailgulek / @giomfo could you please look into this?

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denasescu @vpetrykov @CLAassistant